Skip to content

[PECOBLR-2461] Fix test_show_columns_blocked: SHOW COLUMNS now allowed in MST#778

Merged
vikrantpuppala merged 1 commit intomainfrom
vikrantpuppala/fix-mst-show-columns-allowed
Apr 23, 2026
Merged

[PECOBLR-2461] Fix test_show_columns_blocked: SHOW COLUMNS now allowed in MST#778
vikrantpuppala merged 1 commit intomainfrom
vikrantpuppala/fix-mst-show-columns-allowed

Conversation

@vikrantpuppala
Copy link
Copy Markdown
Contributor

Summary

test_show_columns_blocked started failing on main after PR #775 merged (example CI run). Root cause: the server's MSTCheckRule allowlist has been broadened to include SHOW COLUMNS (ShowDeltaTableColumnsCommand), so executing SHOW COLUMNS IN <table> inside an MST transaction no longer raises.

This PR flips the test to assert SHOW COLUMNS succeeds inside an active transaction, mirroring the existing test_describe_table_not_blocked pattern.

All other MST-blocked SQL assertions (SHOW SCHEMAS / TABLES / CATALOGS / FUNCTIONS, DESCRIBE QUERY, DESCRIBE TABLE EXTENDED, information_schema) still correctly raise, so the rest of the TestMstBlockedSql class is unchanged.

Changes

  • Renamed test_show_columns_blockedtest_show_columns_not_blocked and switched it to _assert_not_blocked.
  • Updated the TestMstBlockedSql class docstring to reflect the current allowlist (SHOW COLUMNS moved from Blocked → Allowed).

Test plan

  • Re-run e2e suite on main after merge; test_show_columns_not_blocked should PASS.
  • Confirm other TestMstBlockedSql::test_show_*_blocked tests still PASS.

This pull request and its description were written by Isaac.


This PR was created with GitHub MCP.

…d in MST

The server's MSTCheckRule allowlist has been broadened to include
SHOW COLUMNS (ShowDeltaTableColumnsCommand). Flip the test to assert
SHOW COLUMNS succeeds inside an MST transaction, matching the pattern
already used by test_describe_table_not_blocked.

Other SHOW variants (SHOW SCHEMAS/TABLES/CATALOGS/FUNCTIONS),
DESCRIBE QUERY, DESCRIBE TABLE EXTENDED, and information_schema remain
blocked as expected.

Co-authored-by: Isaac
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
@vikrantpuppala vikrantpuppala force-pushed the vikrantpuppala/fix-mst-show-columns-allowed branch from 4d82936 to e7d8037 Compare April 23, 2026 09:46
@vikrantpuppala vikrantpuppala merged commit ee63b81 into main Apr 23, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants